Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long doc build time for single figure in intro to Catalyst #994

Closed
TorkelE opened this issue Jul 21, 2024 · 5 comments
Closed

Fix long doc build time for single figure in intro to Catalyst #994

TorkelE opened this issue Jul 21, 2024 · 5 comments
Labels

Comments

@TorkelE
Copy link
Member

TorkelE commented Jul 21, 2024

This figure in the introduction to the docs:
image
still causes really long doc build times.

Changing the code block to

plot(sol)
plot(sol, density = 10000, fmt = :png) # hide
nothing # hide

reduced doc build time from 700-800 seconds to around 150 (after the first run which compiles stuff). Just reducing the density did not necessarily seem to have that effect though.

Does not need to be fixed soon, and I am not sure what the best approach is, but would be nice to figure out at some point since it makes writing documentation a lot more annoying.

@TorkelE TorkelE added the bug label Jul 21, 2024
@isaacsas
Copy link
Member

This seems like a documenter bug — it seems to be ignoring the request in the doc to plot this as a png and is still plotting it as a svg.

@isaacsas
Copy link
Member

isaacsas commented Jul 21, 2024

We shouldn’t reduce the density — it leads to a misleading plot that does not correctly illustrate the noise in the model.

@TorkelE
Copy link
Member Author

TorkelE commented Jul 21, 2024

I checked the plots with/without density and looked fine, but if you saw a difference then Ok.

@TorkelE
Copy link
Member Author

TorkelE commented Jul 21, 2024

The Documenter people suggest that the solution my be to use DisplayAs.jl, and that might work better than simply designating :png in the plot command. https://tkf.github.io/DisplayAs.jl/dev/#DisplayAs.PNG

@isaacsas
Copy link
Member

Closed #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants