Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BlinkCmpStatus command #809

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

bydlw98
Copy link
Contributor

@bydlw98 bydlw98 commented Dec 28, 2024

The command :BlinkCmpStatus can be used to view which sources providers are enabled or not enabled.

This is inspired by and implemented based on the :CmpStatus command from hrsh7th/nvim-cmp.

The command `:BlinkCmpStatus` can be used to view which sources
providers are enabled or not enabled.

This is inspired by and implemented based on the `:CmpStatus` command
from `hrsh7th/nvim-cmp`.
@tristan957
Copy link

Should we instead just have a top-level Blink command, so it would be :Blink status? Makes it easy to do lazy loading for lazy.nvim since you just need to do cmd = "Blink".

@bydlw98
Copy link
Contributor Author

bydlw98 commented Jan 8, 2025

Interesting idea. Another option could be naming the top-level command BlinkCmp.

Let's see Saghen's thoughts on this and I'll update the pull request accordingly.

@Saghen
Copy link
Owner

Saghen commented Jan 8, 2025

Renaming to BlinkCmp makes sense to me! Perhaps we should move this to a top level lua/comands.lua as well

With this commit the `:BlinkCmpStatus` command is removed and replaced
with the `:BlinkCmp status` command.
@bydlw98
Copy link
Contributor Author

bydlw98 commented Jan 11, 2025

Hi Saghen, I have moved BlinkCmpStatus to top level lua/blink/cmp/commands.lua and into top-level command BlinkCmp

Please review and feedback.

@Saghen Saghen merged commit 86c9676 into Saghen:main Jan 11, 2025
2 checks passed
@Saghen
Copy link
Owner

Saghen commented Jan 11, 2025

Thank you! I've merged this with the health check on main to match the behavior of nvim-lspconfig

@bydlw98 bydlw98 deleted the feat/add-BlinkCmpStatus-command branch January 25, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants