-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: implement auto-insert option #65
Conversation
Maybe there should be only one option for selection behaviour, e.g |
That's a much better idea than having two separate booleans yes! Will implement that tomorrow. |
3526e86
to
1a3c4c5
Compare
77c75cd
to
453fc0f
Compare
I think the PR is ready to be reviewed @Saghen. I'm still not sure about the first checklist point, and I also added another comment. I tested as much edge cases as I could think of with |
I've added a wrapper on the |
Closes #34
Still left to do:
trigger.triggered_by
). I'm open to suggestions on this one.preselect = false
whenauto_insert = true
. We could turnpreselect
off whenauto_insert
is on and print a message onsetup
warning the user about the incompatibility, wdyt?accept
when implicitly accepting a completion item by selecting it and pressing a non-completable character (like(
for ex) as mentioned here Allow auto-inserting completion items #34 (comment).