-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(download): correctly handle download = false
and implementationn = "rust"
#1334
Conversation
…n = "rust"` Previously, this set of options would result in the lua implementation being used. The new flow should be more linear and easy to follow.
9612532
to
ec0c908
Compare
Much cleaner, thank you! |
hmm, after this PR I get this warning:
But I'm using nix, and the binary is provided by just using Before lua implementation all worked fine, so I suspect that it still does but now I get this warning. PS setting
|
The latest change should bypass the prebuilt binaries entirely when on nix (no need to set download false). Lmk if that works for you |
Something is still of with the
I think whatever the issue around downloads was, there's still something off about the path resolution of the .so file, even if it's included with the flake. Any way to provide a path statically? I'll try to find you some more info to work with. |
yeah, still the same issue, but I'm pretty sure the so file is properly loaded. |
watch out, this is a big one 😄 #1356 |
Previously, this set of options would result in the lua implementation being used. The new flow should be more linear and easy to follow, with more descriptive and specialized error messages.