Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ghost text with noice #1269

Merged
merged 4 commits into from
Feb 20, 2025
Merged

feat: support ghost text with noice #1269

merged 4 commits into from
Feb 20, 2025

Conversation

Saghen
Copy link
Owner

@Saghen Saghen commented Feb 18, 2025

Closes #939

@folke Curious on your thoughts on this, I've used an internal API (require('noice.ui.cmdline').position) but the result is quite promising! Perhaps this internal API could be made official? I've started using this with:

cmdline = {
  keymap = { 
    ['<Tab>'] = { 'accept' },
    ['<C-Space>'] = { 'show_and_insert' }
  },
  completion = {
    menu = { auto_show = false },
    ghost_text = { enabled = true },
  },
}

image

@folke
Copy link
Contributor

folke commented Feb 19, 2025

Nice! Will check it out

@Saghen Saghen merged commit 9cbbcc0 into main Feb 20, 2025
5 of 6 checks passed
@Saghen Saghen deleted the noice-ghost-text branch February 20, 2025 18:41
@minusfive
Copy link
Contributor

Nice! Will check it out

I'm so disappointed you didn't reply "Noice! ..."

@skbolton
Copy link

Is noice a requirement? I do not use it and now I am getting failures here

@krovuxdev
Copy link

@skbolton Hi, please check the issues section to report any problems you are experiencing. Also, please try with repro.lua

Saghen added a commit that referenced this pull request Feb 26, 2025
@Saghen
Copy link
Owner Author

Saghen commented Feb 26, 2025

@skbolton Does that commit resolve the issue for you?

@skbolton
Copy link

skbolton commented Feb 26, 2025

@Saghen no unfortunately. I am using this package as an input in my nix flake. I just pulled and rebuilt and I am getting failures here still.

For additional context the ghost text is showing for me
Screenshot 2025-02-26 at 17 03 34 Medium

But when I press delete I get the error
image

I don't have any config around cmdline in my config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost text in cmdline completions
5 participants