Expire after bug #196
Merged
Expire after bug #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merged observable should not be completed or failed, if a single item is completed or failed.
|
Thanks, this looks good to me. Before I merge it, I will have a think about whether the fix should be applied in |
|
You are welcome. I am not sure what I broke with that. Besides, I realized that my fix is the only place where OnCompleted and OnError is discarded and I am not sure, if this is the correct pattern. |
|
You broke nothing. My thought is whether the issue can also exist with subscribe many. Accounting for your comments it almost certainly does not |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to resolve #187.
I think the root cause of this issue was, that MergeMany propagates OnCompleted from all items to the outside observer. So when the first item's remove is executed and the observable started with Observable.Timer is completed, the overall stream is completed an the remove of subsequent items will not be executed.
Please review my changes to MergeMany. I am ignoring OnCompleted and OnError and I am not sure, if this is the correct thing to do.