Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Improper Lock #153

Closed
Noggog opened this issue Sep 10, 2018 · 2 comments
Closed

Potential Improper Lock #153

Noggog opened this issue Sep 10, 2018 · 2 comments
Labels

Comments

@Noggog
Copy link
Contributor

Noggog commented Sep 10, 2018

Probably not a large issue since it's an internal class, but I thought I'd bring up
/~https://github.com/RolandPheasant/DynamicData/blob/master/DynamicData/Cache/Internal/ReaderWriter.cs#L86

Looks improper at a glance to be locking this, and doesn't line up with the rest of the class' locking system. If it's on purpose, sorry about the bother. 8)

@RolandPheasant
Copy link
Collaborator

You're right. That's a dumb error that needs fixing.

@RolandPheasant
Copy link
Collaborator

RolandPheasant commented Sep 10, 2018

I have fixed the locking and deployed a patch to Nuget.

Thanks for point the error out.

@lock lock bot added the outdated label Jul 9, 2019
@lock lock bot locked and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants