Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component is hanging the Chrome browser #385

Closed
gnemtsov opened this issue May 21, 2018 · 5 comments
Closed

Component is hanging the Chrome browser #385

gnemtsov opened this issue May 21, 2018 · 5 comments

Comments

@gnemtsov
Copy link

gnemtsov commented May 21, 2018

Hello!

I am having problems with the component. It happens both with effect="float" and effect="solid". I think it can be reproduced by minimizing the screen size so that cursor will be over the tooltip, when it appears.
Here is the output in developer console (browser just hangs):
image
Hope this can be reproduced and fixed. I like the component very much. Thank you for your work!

@aronhelser
Copy link
Collaborator

I see .updatePosition() on the call stack - may be a recent regression when we added that call inside .showToolTip(). Would you mind trying an earlier version, maybe 3.4.0, and seeing if this bug reproduces?

@gnemtsov
Copy link
Author

gnemtsov commented May 23, 2018

Yes, you are right. If I downgrade to version 3.4.0, this problem disappears.
Positioning is sometimes wrong, but it is not so critical as browser hanging.
I use tooltip component for showing form fields descriptions:
image

@aronhelser
Copy link
Collaborator

The extra .getPosition was introduced here:
#310

@P0lip
Copy link
Contributor

P0lip commented May 26, 2018

With some certainty I may say the following PR causes this.
I've also faced a similar issue and after a downgrade to the version (3.4.0?) that didn't have that piece of code, everything started working smoothly again.

In my case updatePosition was being called infinitely due to the fact place !== desiredPlace was truthy and then that function returned { isNewState: true }

Could you see if removing that desiredPlace change would do the trick for you?

@gris-martin
Copy link
Contributor

This PR might have fixed this issue: #391. In it, desiredPlace is altered to play more nicely with place and isNewState. Can someone verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants