-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with React 16 #342
Comments
heya @bradennapier did you end up finding a work around for this? I saw your comment in the React repo! |
Hey @emily-plummer this happens when you have two versions of React installed. This was due to a repo which I was not even including but since it was in my package.json it was causing an issue.
revealed that repo easily and upon removing it this problem instantly resolved. So it was not an issue with That being said, I will leave this open for a little while so others can see it -s ince we have 7 thumbs up already I would assume quite a few are running into this! |
I've been running the plugin in production for over a week now and had no problems... |
Correct, you will not have problems unless there is a module that has React < 16 in its dependencies rather than peerDependencies where it should be. |
Rad! Thanks @bradennapier :) |
Wait.. so what was this fix? Moving |
No, it wasnt react-tooltip that was the problem, if ANY of your dependencies or their dependencies have react as a dependency rather than peerDependency then any calls that utilize enqueue callback
will generate this error. if you run the
or
on your app you should see a package that has react as a dependency -- that package needs to move it to peerDependencies or you need to remove that package. Even if you do not use that package and it is never imported - it appears to cause a conflict. |
This line: /~https://github.com/wwayne/react-tooltip/blob/master/package.json#L42 Needs to change to this: /~https://github.com/eiriklv/react-masonry-component/blob/master/package.json#L39 Or what this PR is doing: |
Merged and deployed as 3.4.0 |
This package breaks any app using it once updated to React 16
The text was updated successfully, but these errors were encountered: