Total Available Memory Confusion

[sivetic]

There seems to still be confusion between what units GetPhysicalmemory() returns. Comment in MachineInfo.cpp reads that total physical memory returned is in kilobytes, however extractor.cpp divides the value by 1024_1024_1024, which assumes the memory returned is in bytes. I believe there was a ticket in the old SVN system for this.

In addition, at least on my Ubuntu machine, sysconf(_SC_PHYS_PAGES) * sysconf(_SC_PAGESIZE) returns the total memory in bytes, meaning that the result should be divided by 1024 to stay consistent with Apple/FreeBSD/Windows results.

[DennisOSRM]

Full ACK.

[DennisOSRM]

That part of the code is not used anymore.