Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorconfig: Swap out property for key; alias with attr-name #3272

Merged
merged 2 commits into from
Dec 5, 2021
Merged

editorconfig: Swap out property for key; alias with attr-name #3272

merged 2 commits into from
Dec 5, 2021

Conversation

hoonweiting
Copy link
Contributor

This PR replaces the property token with key, and aliases it to the standard token attr-name. This PR also replaces the string alias with attr-value for the value token. These changes bring editorconfig in line with INI and systemd.

@hoonweiting hoonweiting mentioned this pull request Dec 5, 2021
Open
@github-actions
Copy link

github-actions bot commented Dec 5, 2021 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +3 B (+1.3%).

file master pull size diff % diff
components/prism-editorconfig.min.js 236 B 239 B +3 B +1.3%

Generated by 🚫 dangerJS against e580a2c

@RunDevelopment RunDevelopment merged commit bee6ad5 into PrismJS:master Dec 5, 2021
@RunDevelopment
Copy link
Member

Thanks @hoonweiting!

@hoonweiting hoonweiting deleted the 3170-editorconfig-key branch December 5, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoonweiting @RunDevelopment