Core: Removed env.elements for 'before-highlightall' #1968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
env.elements
property from the environment of thebefore-highlightall
hook.Why?
env.selector
. Even if a plugin usingelements
wanted to respectselector
it would not be able to because 1) there might be plugins after it (inbefore-highlightall
) extending the selector and 2) the plugin has no access to the currentcontainer
.Isn't this a breaking change?
Yes, but I don't think that this will have any impact for the above reasons and because from a user perspective, it's hard to use than just iteration over your elements and calling
Prism.highlightElement
yourself.