修改paddlecloud以便于PFSSever取得token #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
changed the title
Yancey1989
reviewed
Jun 21, 2017
paddlecloud/paddlecloud/urls.py
Outdated
| @@ -31,7 +31,7 @@ | |||
| url(r"^api/v1/logs/", paddlejob.views.LogsView.as_view()), | |||
| url(r"^api/v1/workers/", paddlejob.views.WorkersView.as_view()), | |||
| url(r"^api/v1/quota/", paddlejob.views.QuotaView.as_view()), | |||
| url(r"^api/v1/file/", paddlejob.views.SimpleFileView.as_view()), | |||
| url(r"^api/v1/token2user/", paddlejob.views.GetUserView.as_view()), | |||
There was a problem hiding this comment.
Why we delete the simplefile API?
There was a problem hiding this comment.
merge的时候出了点问题。非常感谢。
Done。
typhoonzero
reviewed
Jun 26, 2017
paddlecloud/paddlejob/views.py
Outdated
|
|
||
| def get(self, request, format=None): | ||
| content = { | ||
| 'user': unicode(request.user.username), # `django.contrib.auth.User` instance. |
There was a problem hiding this comment.
We use user's email as username all the time, and emails are strictly checked. Also using django's model values will return unicode typed strings by default.
So don't convert the type.
paddlecloud/notebook/views.py
Outdated
| @@ -44,6 +44,7 @@ def get(self, request, format=None): | |||
| } | |||
| return Response(content) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
What does this blank line do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.