Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon, loaded from wrong location #454

Merged
merged 5 commits into from
Jul 5, 2018
Merged

Conversation

varunarora
Copy link

@daming-lu Could you please pull this branch, and see if you can fix the path to where the favicon should be loaded from?

Will fix #426.

@varunarora varunarora requested a review from daming-lu May 21, 2018 23:59
@jetfuel jetfuel self-requested a review May 22, 2018 21:51
Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickyfantasy nickyfantasy merged commit 4484492 into develop Jul 5, 2018
@ZeyuChen ZeyuChen deleted the add-favicon branch February 29, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add favicon
4 participants