Run optimizer inside parallel do if the forward pass contains parallel do. #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
requested review from
reyoung,
jacquesqiao,
dzhwinter,
QiJune and
tonyyang-svail
helinwang
force-pushed
the
optimizer
branch
4 times, most recently
from
dda30ba to
01af44a
Compare
| if (!exists && platform::is_gpu_place(place)) { | ||
| auto *dst = sub_scope->Var(param)->GetMutable<LoDTensor>(); | ||
| framework::TensorCopy(src, place, dst); | ||
| } |
There was a problem hiding this comment.
parallel_do_op.cc:150: Tab found; better to use spaces [whitespace/tab] [1]
parallel_do_op.cc:151: Tab found; better to use spaces [whitespace/tab] [1]
parallel_do_op.cc:152: Tab found; better to use spaces [whitespace/tab] [1]
parallel_do_op.cc:153: Tab found; better to use spaces [whitespace/tab] [1]
parallel_do_op.cc:156: Tab found; better to use spaces [whitespace/tab] [1]
|
Closing, this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8592
Tested work on parallel do version (modified
test_recognize_digits.py) with or without NCCL (both converges), also tested on non-parallel version fit a line.Ready for review to see if you guys agree with the general direction, and I need to do more testing. Thanks!