Fix/copyfrom context #6954
Merged
Fix/copyfrom context #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
reviewed
Dec 25, 2017
paddle/framework/tensor_util.h
Outdated
| /** | ||
| * @brief CopyFrom support CPU <-> CPU | ||
| */ | ||
|
|
There was a problem hiding this comment.
Delete the redundant black line.
paddle/framework/tensor_util.h
Outdated
|
|
||
| auto size = src.numel() * SizeOfType(src.type()); | ||
|
|
||
| if (platform::is_cpu_place(src_place) && platform::is_cpu_place(dst_place)) { |
There was a problem hiding this comment.
How about use PADDLE_ENFORCE to checkt the place?
| dst->Resize({static_cast<int64_t>(src.size())}); | ||
| auto dst_ptr = static_cast<void*>(dst->mutable_data<T>(dst_place)); | ||
| auto size = src.size() * sizeof(T); | ||
|
|
There was a problem hiding this comment.
CopyToVector create a cpu_place inside. No need to check it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6948