Silu double grad #53605
Merged
Silu double grad #53605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… silu_double_grad
… silu_double_grad
cxxly
previously approved these changes
May 12, 2023
cxxly
reviewed
May 12, 2023
| const Tensor& grad_x_grad, | ||
| Tensor* grad_x, | ||
| Tensor* grad_out_grad) { | ||
| auto exp_neg_x = exp<T>(-x); |
There was a problem hiding this comment.
replace e^-x with out in next pr.
There was a problem hiding this comment.
done in this pr
zyfncg
approved these changes
May 15, 2023
| @@ -0,0 +1,393 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
other pr will modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-66975
silu， tanh 的静态图二阶compositeOpMaker自动生成在名称上有误，修改成本高，暂时不处理。由于静态图目前可通过flag控制在一阶进行拆解，后续需完善高阶下动静统一的执行路线后修复代码生成问题。
2.将一阶拆解逻辑和二阶拆解逻辑分别在两个文件中实现，以便管理。
3.修复机制，当yaml中无kernel，无invoke,只有composite时的相关解析逻辑
原始yaml 解析逻辑判断如果没有invoke字段则一定需要有kernel字段以生成调用的执行路径（c++ api 或 invoke的其他c++api),此pr新增的op yaml 只具备composite 的执行方式，因此需要适配解析逻辑