Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine activation function pointer for LSTM operator. #5251

Merged
merged 7 commits into from
Nov 3, 2017
Merged

Refine activation function pointer for LSTM operator. #5251

merged 7 commits into from
Nov 3, 2017

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Oct 31, 2017 •
edited
Loading

  1. Enable activation selecting in LSTM operator
    Fix Enable activation selecting in LSTM operator. #5337
  2. Fix the gradient check with double type on GPU GTX 1080.

@qingqing01 qingqing01 changed the title [Testing on TeamCity Env]Refine activation function pointer for LSTM operator. Refine activation function pointer for LSTM operator. Nov 1, 2017
luotao1
luotao1 approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
These codes are much cleaner now!

@luotao1 luotao1 merged commit a8dee3b into PaddlePaddle:develop Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@guoshengCS guoshengCS Awaiting requested review from guoshengCS

@hedaoyuan hedaoyuan Awaiting requested review from hedaoyuan

@tonyyang-svail tonyyang-svail Awaiting requested review from tonyyang-svail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingqing01 @luotao1