add autogen code support for logical_and, logical_not, logical_or and logical_xor #52451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
| infer_meta : | ||
| func : ElementwiseInferMeta | ||
| kernel : | ||
| func : logical_xor |
There was a problem hiding this comment.
添加data_type : x，其他算子类似，对应于GetExpectedKernelType
paddle/phi/api/yaml/legacy_ops.yaml
Outdated
There was a problem hiding this comment.
删除paddle/fluid/operators/controlflow/logical_op.cc。删除paddle/fluid/operators/controlflow/CMakeLists.txt中的USE_OP_ITSELF(equal_all);\n
|
|
||
| REGISTER_BINARY_LOGICAL_OP(logical_and, "$$Out = X \\&\\& Y$$"); | ||
| REGISTER_BINARY_LOGICAL_OP(logical_or, "$$Out = X || Y$$"); | ||
| REGISTER_UNARY_LOGICAL_OP(logical_not, "$$Out = !X$$"); |
There was a problem hiding this comment.
由于Python端的logical_not引用了这里的comment，所以需要完善对应的Python API的comment。建议如下：
python/paddle/tensor/logic.py文件下的def logical_not(x, out=None, name=None):,去除装饰器@templatedoc(),并做出修改：
Returns:
Tensor: ${out_comment}
修改为：
Returns:
N-D Tensor. A location into which the result is stored. It's dimension equals with ``x``.
并且@sunzhongkai588i，或@Ligoml进行review
|
@Ligoml,麻烦review一下PR |
|
hi, @ScottWong98
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
add autogen code support for
logical_and,logical_not,logical_orandlogical_xor.#51842