fix attr bug in op_test and ensure order in duplicate inputs/outputs #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xreki
previously approved these changes
Sep 11, 2017
qingqing01
reviewed
Sep 11, 2017
| kwargs = dict() | ||
|
|
||
| for in_name, in_dup in Operator.get_op_inputs(op_type): | ||
| if in_name in inputs: | ||
| kwargs[in_name] = [] | ||
| if in_dup: | ||
| sub_in = inputs[in_name] | ||
| for sub_in_name in sub_in: | ||
| for sub_in_name, arr in sub_in: |
There was a problem hiding this comment.
for sub_in_name, _ in sub_in:| for sun_in_name in sub_in: | ||
| var = scope.new_var(sun_in_name) | ||
| kwargs[out_name].append(sun_in_name) | ||
| for sub_in_name, arr in sub_in: |
There was a problem hiding this comment.
for sub_in_name, _ in sub_in:| @@ -46,10 +47,9 @@ def set_input(scope, op, inputs, place): | |||
| if in_name in inputs: | |||
| if in_dup: | |||
| sub_in = inputs[in_name] | |||
| for sub_in_name in sub_in: | |||
| for sub_in_name, arr in sub_in: | |||
There was a problem hiding this comment.
Make name more clear.
for sub_in_name, sub_array in sub_in:
| @@ -168,7 +168,11 @@ def get_gradient(scope, op, inputs, outputs, grad_name, place, | |||
| class OpTest(unittest.TestCase): | |||
| def check_output_with_place(self, place): | |||
| self.scope = core.Scope() | |||
| self.op = create_op(self.scope, self.op_type, self.inputs, self.outputs) | |||
| op_inputs = self.inputs if hasattr(self, "inputs") else dict() | |||
| op_outputs = self.outputs if hasattr(self, "outputs") else dict() | |||
There was a problem hiding this comment.
When the users could not set self.inputs and self.outputs ? Aren't they always needed?
There was a problem hiding this comment.
Some operator, like random operator has no input. NOP has no input and output.
I will remove self.outputs here.
|
Need to add "Fix [issue url]" in the PR description. |
Xreki
approved these changes
Sep 11, 2017
qingqing01
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4019