Move transpose to pten #39327
Merged
Move transpose to pten #39327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
chenwhql
reviewed
Feb 24, 2022
| @@ -43,7 +43,7 @@ def check_network_convergence(cls, | |||
| get_data_from_feeder=None, | |||
| use_parallel_executor=True, | |||
| use_reduce=False, | |||
| use_ir_memory_optimize=True, | |||
| use_ir_memory_optimize=False, | |||
There was a problem hiding this comment.
这个会导致 memory optimize会挂。。我问了，已经没有人再用这个组件了。
| auto* out_ptr = out->data<T>(); | ||
|
|
||
| // copy in_stride, out_stride, axis to gpu device | ||
| const paddle::platform::CUDAPlace& cuda_place = context.GetPlace(); |
|
|
||
| // copy in_stride, out_stride, axis to gpu device | ||
| const paddle::platform::CUDAPlace& cuda_place = context.GetPlace(); | ||
| paddle::platform::CPUPlace cpu_place = paddle::platform::CPUPlace(); |
zyfncg
reviewed
Feb 24, 2022
| const int ndims, const Tensor& in, | ||
| const std::vector<int32_t> perm, Tensor* out) { | ||
| void TransposeGPUKernelDriver(const phi::GPUContext& dev_ctx, const int ndims, | ||
| const Tensor& in, const std::vector<int32_t> perm, |
| #include <vector> | ||
| #include "paddle/phi/api/ext/dispatch.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/transpose_kernel.h" |
There was a problem hiding this comment.
"paddle/phi/kernels/transpose_kernel.h"在开头比较符合规范
| #pragma once | ||
|
|
||
| #include "paddle/phi/kernels/funcs/math_function.h" | ||
| #include "paddle/phi/kernels/transpose_grad_kernel.h" |
There was a problem hiding this comment.
是不不需要#include "paddle/phi/kernels/transpose_grad_kernel.h"?
… move_transpose_to_pten
… move_transpose_to_pten
… move_transpose_to_pten
chenwhql
approved these changes
Feb 28, 2022
|
|
||
| // copy in_stride, out_stride, axis to gpu device | ||
| const phi::GPUPlace& cuda_place = context.GetPlace(); | ||
| phi::CPUPlace cpu_place = paddle::platform::CPUPlace(); |
There was a problem hiding this comment.
paddle::platform::CPUPlace -> phi::CPUPlace
zyfncg
approved these changes
Feb 28, 2022
| #include "paddle/phi/common/bfloat16.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/funcs/math_function.h" | ||
| #include "paddle/phi/kernels/impl/transpose_grad_kernel_impl.h" |
|
|
||
| // copy in_stride, out_stride, axis to gpu device | ||
| const phi::GPUPlace& cuda_place = context.GetPlace(); | ||
| phi::CPUPlace cpu_place = paddle::platform::CPUPlace(); |
Aurelius84
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
OPs
Describe
move transpose op to pten