Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make attribute support for std::vector<std::pair<int, int>> #3878

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Make attribute support for std::vector<std::pair<int, int>> #3878

merged 1 commit into from
Sep 6, 2017

Conversation

wanghaoshuang
Copy link
Contributor

fix #3877

@JiayiFeng
Copy link
Collaborator

JiayiFeng commented Sep 5, 2017 •
edited
Loading

Why std::vector<std::pair<int, int>> is necessary? How will it be used as a pad Op attribute?

@wanghaoshuang
Copy link
Contributor Author

@Canpio
std::vector<std::pair<int, int>> is used to describe the rules of padding. For a 2-d image input, [(0,1), (2,3)] means left_pad=0, right_pad=1, top_pad=2 and bottom_pad=3.

JiayiFeng
JiayiFeng approved these changes Sep 6, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghaoshuang wanghaoshuang merged commit 7002e69 into PaddlePaddle:develop Sep 6, 2017
@wanghaoshuang wanghaoshuang deleted the fix_attr branch May 20, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make attribute support for std::vector<std::pair<int, int>>
2 participants
@wanghaoshuang @JiayiFeng