add lod tensor interface design #3454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
requested review from
reyoung,
wangkuiyi,
qingqing01 and
jacquesqiao
wangkuiyi
reviewed
Aug 14, 2017
|
|
||
| - 基本设计完全按照8-11（上周五）讨论的方案，只有如下变化 | ||
| - 由于目前只有2种tensor，难以确保将来是否有其他类似 `LOD` 角色的Tensor，因此本设计不会将 `LODTensor` 直接作为 Interface，而是将最基础的Tensor概念作为Interface | ||
| - 目前实现的Tensor会更名为 `DenseTensor` |
There was a problem hiding this comment.
目前不需要把Tensor改成DenseTensor吧。我理解只需要约定所有需要用到Tensor的地方都用LODTensor即可？
There was a problem hiding this comment.
了解，那我把 Tensor 全局替换成 LODTensor 应该就可以了
| - 更复杂的类型问题，将推迟到有了2个以上Tensor 类型的时候考虑 | ||
|
|
||
| ## Tensor 作为Interface | ||
| `Tensor interface` 直接对应其他平台的相同概念，但LODTensor无法； 稠密的为 DenseTensor，稀疏的为 SparseTensor。 |
There was a problem hiding this comment.
这个提取interface的工作也是几个月之后才会需要做的吧？
There was a problem hiding this comment.
但暂时，LODTensor 只有在变长RNN的时候才开始用到，暂时只是定长RNN，这个阶段所有的Op都只需要Tensor。
这个替换是临时解决方案，是否hold到变长RNN的时候再全局替换（应该也在小demo，RNN定长demo两个阶段之后了）。
理解的是，如果是通用解决方案，可以现在合入，如果临时解决方案，就等到需要的时候合入？
| ### 所有的InferShape里在最开始添加var 的Clone，以实现类型传递 | ||
|
|
||
| ```c++ | ||
| T* VarClone(const Variable& var){ |
There was a problem hiding this comment.
如果现在只有LODTensor在实际使用，是不是也就不需要clone了？
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.