Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The right way to link to nnpack #5863

Closed
wangkuiyi opened this issue Nov 23, 2017 · 2 comments
Closed

The right way to link to nnpack #5863

wangkuiyi opened this issue Nov 23, 2017 · 2 comments
Assignees

Comments

@wangkuiyi
Copy link
Collaborator

In our root CMakeLists.txt file, we have

Paddle/CMakeLists.txt

Lines 177 to 180 in d883547

if(USE_NNPACK)
include(external/nnpack)
list(APPEND EXTERNAL_LIBS ${NNPACK_LIBS})
endif(USE_NNPACK)

It uses the special variable EXTERNAL_LIBS.

@hedaoyuan I am wondering why glog and gflags and many other third-party libraries don't need to be added to EXTERNAL_LIBS, but nnpack has to be?

Could @gangliao have a look at this issue as well? Thanks!

@gangliao
Copy link
Contributor

glog and gflags and many other third-party libraries are also included.

Paddle/CMakeLists.txt

Lines 156 to 163 in d883547

set(EXTERNAL_LIBS
${GFLAGS_LIBRARIES}
${GLOG_LIBRARIES}
${CBLAS_LIBRARIES}
${PROTOBUF_LIBRARY}
${ZLIB_LIBRARIES}
${PYTHON_LIBRARIES}
)

@wangkuiyi

@wangkuiyi
Copy link
Collaborator Author

@gangliao Got it. Thanks. I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants