You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OperatorBase::Init duplicates with the C++ constructor mechanism. We should remove it.
It seems that people wrote this duplicated mechanism because the constructor of OperatorBase is over-simplified to take no parameters, and OpRegistry::CreateOp would new an operator instance and set OperatorBase:: directly -- the core problem is that OperatorBase's properties are declared public instead of protected.
OperatorBase::Init duplicates with the C++ constructor mechanism. We should remove it.
It seems that people wrote this duplicated mechanism because the constructor of OperatorBase is over-simplified to take no parameters, and OpRegistry::CreateOp would new an operator instance and set OperatorBase:: directly -- the core problem is that OperatorBase's properties are declared
public
instead ofprotected
.So, to fix this issue we need to
protected
so that we need to
The text was updated successfully, but these errors were encountered: