-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block stairs are not following the curve #6314
Comments
From @Khoyo : we should probably try to reproduce locally, so we can attach a debugger and check if it's a standalone simulation issue, or related to signals. |
While reproducing with @axrolld we noticed 2 things:
The good news from 2. is that we can reproduce easily by creating a train and adding a (non-null) stop |
One issue is that we "miss" the first stop, I put logs below for an example on small_infra where the position and stop position are never equal. /~https://github.com/osrd-project/osrd/blob/2a2abf970bd562137ce7ff3389ae5fa83219d50f/core/src/main/java/fr/sncf/osrd/standalone_sim/EnvelopeStopWrapper.java#L57
Checking all stops (instead of just the next one) could fix the issue, but the problem seems deeper. |
From @eckter: we should probably check we are passed the stop, instead of at the stop. |
What happened?
With allowances :
Without :
What did you expect to happen?
The blocks are supposed to follow the green curve if there's one, the blue curve if not.
How can we reproduce it (as minimally and precisely as possible)?
This does not always happen but i had this bug on train 876401 here.
What operating system, browser and environment are you using?
OSRD version (top right corner
Account
button >Informations
)3a2b863
The text was updated successfully, but these errors were encountered: