Error on customer screen in admin area

[Caprico85]

I think the recent upgrade to OpenMage 20.12.0 introduced an error on the customer screen in the admin area.

The tab menu now looks like this:

This is a screenshot from our heavily modified OpenMage install. I had no time to verify this on an unmodified OpenMage install. But I am pretty sure it would happen there too.

---

The problem can be traced to these changes:

diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php
index a34ce76507a..ef85b2ecdd6 100644
--- a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php
+++ b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php
@@ -165,7 +165,11 @@ function(v, elem){
                             ->__('Password must be at least of %d characters.', $minPasswordLength),
                     ],
                 );
-                $field->setRenderer($this->getLayout()->createBlock('adminhtml/customer_edit_renderer_newpass'));
+
+                $renderer = $this->getLayout()->createBlock('adminhtml/customer_edit_renderer_newpass');
+                if ($renderer instanceof Varien_Data_Form_Element_Renderer_Interface) {
+                    $fieldset->setRenderer($renderer);
+                }
 
                 // Prepare customer confirmation control (only for existing customers)
                 $confirmationKey = $customer->getConfirmation();

Previously, you called "$field->setRenderer". Since 20.12.0 you call "$fieldset->setRenderer". If I change back the $fieldset to $field, the menu works again.

As far as i see, there are 3 different lines with this problem. Line 171, line 212 and line 236.

[sreichel]

Sorry, PR comes in next hour.