Fix: resend msgs when client_thread send failed #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehao
reviewed
Jul 25, 2023
georgehao
reviewed
Jul 25, 2023
![cr-gpt[bot]](/~https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| } | ||
| to_send_.erase(iter); | ||
| NotifyWrite(ip_port); | ||
| } | ||
| } else if (ti.notify_type() == kNotiClose) { | ||
| LOG(INFO) << "received kNotiClose"; |
There was a problem hiding this comment.
Here are some improvements and bug risks to consider in the provided code patch:
Improvements:
- Remove the unnecessary blank line: The blank line at line 32 can be removed for cleaner code formatting.
Bug Risks:
- Accessing invalidated iterators: After swapping
msgswithiter->second, the loop that follows assumes thatmsgscontains the originally stored messages. However, if there are other parts of the code that accessto_send_[ip_port]concurrently and modify it after the swap, the loop may produce unexpected results or even result in undefined behavior due to accessing invalidated iterators. Consider using a different approach to process the messages to avoid this risk.
Overall, without full context and knowledge of the entire codebase, it's difficult to provide an exhaustive review. It's recommended to thoroughly test the modified code for any potential issues and ensure that all other parts of the codebase (not included in the provided snippet) work correctly with these modifications.
AlexStocks
approved these changes
Jul 26, 2023
chejinge
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resend msgs when client_thread send failed and narrow down critical section
Fixes: #1815