You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During investigation of #834, I found an efficiency issue in the current implementation of compute_MVBS if the data is delayed. For the 19 files in the OOI eclipse notebook, if the ds_Sv data are persisted in memory it takes 5 mins to compute, but if ds_Sv is lazy-loaded the operations never finished.
Further investigation by @b-reyes showed that the xarray groupby_bins operations are the major hiccups. The under-the-hood implementation can likely be improved dramatically by doing indexing directly using dask, and we can do this in the next release.
The text was updated successfully, but these errors were encountered:
During investigation of #834, I found an efficiency issue in the current implementation of
compute_MVBS
if the data is delayed. For the 19 files in the OOI eclipse notebook, if the ds_Sv data are persisted in memory it takes 5 mins to compute, but if ds_Sv is lazy-loaded the operations never finished.Further investigation by @b-reyes showed that the xarray groupby_bins operations are the major hiccups. The under-the-hood implementation can likely be improved dramatically by doing indexing directly using dask, and we can do this in the next release.
The text was updated successfully, but these errors were encountered: