Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API for research search #3987

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

goratt12
Copy link
Collaborator

@goratt12 goratt12 commented Nov 5, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Fetching of research articles is being done directly with Firestore

What is the new behavior?

Fetching of research articles have moved to a Remix backend API

If useful, provide screenshot or capture to highlight main changes

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #3924

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@goratt12 goratt12 requested a review from a team as a code owner November 5, 2024 19:46
Copy link

cypress bot commented Nov 8, 2024

onearmy-community-platform    Run #6779

Run Properties:  status check passed Passed #6779  •  git commit 56e7e92bf8: test: added e2e tests
Project onearmy-community-platform
Branch Review pull/3987
Run status status check passed Passed #6779
Run duration 05m 16s
Commit git commit 56e7e92bf8: test: added e2e tests
Committer unknown
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 81
View all changes introduced in this branch ↗︎

@benfurber benfurber force-pushed the 3924-research-remix-backend branch from f32908e to a44c9da Compare January 16, 2025 10:49
@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jan 16, 2025
@benfurber benfurber force-pushed the 3924-research-remix-backend branch from a44c9da to 43f5f5e Compare January 17, 2025 11:00
@benfurber benfurber force-pushed the 3924-research-remix-backend branch from 43f5f5e to 301eb10 Compare January 17, 2025 11:12
@benfurber benfurber force-pushed the 3924-research-remix-backend branch from 301eb10 to 56e7e92 Compare January 17, 2025 14:55
@benfurber benfurber merged commit 18d172e into ONEARMY:master Jan 17, 2025
18 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Research 🔬 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Tech] Create API for research search
4 participants