-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardhat Dependency Graph Doesn't Contain Nested Dependencies #2811
Comments
This issue is also being tracked on Linear. We use Linear to manage our development process, but we keep the conversations on Github. LINEAR-ID: c84dd8b1-3628-48f0-b329-c818dabf299c |
Thanks for reporting this @pingdaze. This is a hard problem to solve because of the way solc works and how we use it. We are thinking of long-term solutions, but in the meantime we should:
Note for ourselves: one way to do this is, during import resolution, and if we are resolving an import inside a library, check if that (second) imported library can be resolved both from the root of the project and from the (first) library. We should also get their respective versions, since that would be useful for the error message. Notice that this can have an impact on performance, so we should probably cache this result, with the pair (lib1, lib2) as a key. |
Any updates on this or at least some workarounds? |
The current workaround is declaring dependencies as peer dependencies. We are currently working on a new major version of Hardhat that properly supports this. |
Hey, any updates on this major version by any luck? I do have the same issue. and I tweak one of those for it to be a |
We released an alpha just this week! https://hardhat.org/hardhat3-alpha |
Local package file contains
@openzeppelin/contracts version:4.6.0
but the 'arb-bridge-eth' package I'm using contains@openzeppelin/contracts version:3.4.2
and since the 4. update the repo doesn't containPausable.sol
leading to a dependency issue since Hardhat is looking for the dependency in my rootnode_modules
instead of the dependenciesnode_modules
where it's actually located.DUMPER.txt
The text was updated successfully, but these errors were encountered: