Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must run onSuccess on pre Build.VERSION_CODES.M #1

Closed
DJafari opened this issue Sep 17, 2017 · 4 comments
Closed

must run onSuccess on pre Build.VERSION_CODES.M #1

DJafari opened this issue Sep 17, 2017 · 4 comments

Comments

@DJafari
Copy link

DJafari commented Sep 17, 2017

i think you must call successListener.onSuccess(); on pre Build.VERSION_CODES.M

/~https://github.com/NoNews/NoPermission/blob/master/library/src/main/java/ru/alexbykov/nopermission/PermissionHelper.java#L58

public void run() {
        if (isNeedAskPermission()) {

            if (successListener != null && failureListener != null && newerAskAgainListener != null) {
                activity.requestPermissions(permissions, PERMISSION_REQUEST_CODE);
            } else
                throw new RuntimeException("OnPermissionSuccessListener or OnPermissionFailureListener not implemented. Use methods: onSuccess and onFailure");
        } else if(successListener != null) {
                successListener.onSuccess();
        }
    }
@NoNews
Copy link
Owner

NoNews commented Sep 18, 2017

Hi @DJafari, thanks for this issue, will fix it in1.0.8

@DJafari
Copy link
Author

DJafari commented Sep 18, 2017

@NoNews yw, i send a pull request to fix some problems and improvements

@NoNews
Copy link
Owner

NoNews commented Sep 18, 2017

@DJafari Thank you, I'll review and merge it today.
Just too I am engaged in refactoring and correction of small bugs, will try to lay out 1.0.8 as soon as possible

@NoNews
Copy link
Owner

NoNews commented Sep 18, 2017

fixed in 1.0.8

@NoNews NoNews closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants