Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable isolatedModules compiler option #8970

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Jan 16, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

https://blog.angular.dev/using-isolatedmodules-in-angular-18-2-68a7d3a6c03d

#8718 is merged, this PR is to enable isolatedModules compiler option for show case website, which means that developers will be able to use isolatedModules to speed up their build process.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Laffery Laffery added this to the v19.1 milestone Jan 16, 2025
Copy link

zorro-bot bot commented Jan 16, 2025

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (f1d8d92) to head (6057ff0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8970   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         555      555           
  Lines       19708    19708           
  Branches     2944     2944           
=======================================
+ Hits        18114    18115    +1     
+ Misses       1267     1266    -1     
  Partials      327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery Laffery requested a review from HyperLife1119 January 16, 2025 06:20
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit 0d42aa7 into NG-ZORRO:master Jan 16, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants