-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(module:*): remove ngClass and ngStyle #8895
refactor(module:*): remove ngClass and ngStyle #8895
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8895 +/- ##
==========================================
- Coverage 91.89% 91.88% -0.02%
==========================================
Files 547 547
Lines 19364 19359 -5
Branches 2866 2866
==========================================
- Hits 17795 17788 -7
- Misses 1254 1255 +1
- Partials 315 316 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like that angular/angular#58860 isn't in a specific angular's version milestone yet, I'll put it in the backlog milestone first, and later we can put it in v19.1
52664c3
to
4415d93
Compare
In fact, I guess we don't have to wait v19.1 :) |
4415d93
to
d67bdff
Compare
Hi, I saw that you were already proactive on this. The native bindings almost support the same usecases at the exception of 2 :
But anyway, you can go ahead with it, as it'll pull less code by dropping the imports of the 2 directives :) |
d67bdff
to
07c944a
Compare
Yes, this is in fact a breaking change, thanks for the insight! @JeanMeche 👍 |
You can still target a minor with this (or even a patch), as it shouldn't break anything if you replace correctly the usages :) |
Since we also allow ngClass/ngStyle values to be passed in by users, not just for internal use, this is a breaking change in our opinion :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
angular/angular#40623
angular/angular#58860
What is the new behavior?
Does this PR introduce a breaking change?
All nzClass / nzStyle input properties no longer support the following features:
Set()
: use arrays insteadOther information