Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:icon): support nz-icon tag selector #8778

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Sep 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

新版本更推荐使用 <nz-icon> 而非 <span nz-icon>,前者更简短清晰,且支持自闭合。

+ <nz-icon nzType="smile" />
- <span nz-icon nzType="smile"></span>

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 21, 2024

This preview will be available after the AzureCI is passed.

@HyperLife1119 HyperLife1119 force-pushed the feat/support-nz-icon-tag branch 2 times, most recently from b32ac5f to 63b578b Compare September 21, 2024 11:18
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (5fec53e) to head (0618b01).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8778      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         537      537              
  Lines       18472    18471       -1     
  Branches     2815     2815              
==========================================
- Hits        16965    16964       -1     
  Misses       1204     1204              
  Partials      303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HyperLife1119 HyperLife1119 force-pushed the feat/support-nz-icon-tag branch from a8adfdb to 0618b01 Compare November 20, 2024 03:22
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 1406241 into NG-ZORRO:master Nov 20, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants