Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:datepicker): ng0956 recreation entire collection #8658

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Nicoss54
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Due to the refactor of the control flow of this component, an issue was raised. NG0956, this issue is a warning raised when a collection of a loop is re create each time on render. This is due to a wrong track parameters

Issue Number: #8653

What is the new behavior?

NG0956 is fixed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Nicoss54 Nicoss54 requested a review from wenqi73 as a code owner July 31, 2024 08:37
Copy link

zorro-bot bot commented Jul 31, 2024

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 force-pushed the fix/datetimepicker-warning branch from bd30c56 to 17d7f98 Compare July 31, 2024 08:43
@Nicoss54 Nicoss54 requested a review from HyperLife1119 July 31, 2024 08:43
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (1b805bb) to head (17d7f98).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8658      +/-   ##
==========================================
- Coverage   91.53%   91.52%   -0.01%     
==========================================
  Files         536      536              
  Lines       18445    18447       +2     
  Branches     2907     2907              
==========================================
+ Hits        16883    16884       +1     
- Misses       1242     1243       +1     
  Partials      320      320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 merged commit 70a0817 into NG-ZORRO:master Jul 31, 2024
9 of 10 checks passed
@Nicoss54 Nicoss54 deleted the fix/datetimepicker-warning branch August 2, 2024 12:03
@Nicoss54 Nicoss54 linked an issue Aug 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NG0956: warning get every time when i open datetime picker
2 participants