Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tooltip, etc): add arrow point at center #7010

Merged
merged 6 commits into from
Nov 22, 2021

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 16, 2021

close #2858

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@pr-triage pr-triage bot added the PR: draft label Oct 16, 2021
@zorro-bot
Copy link

zorro-bot bot commented Oct 16, 2021

This preview will be available after the AzureCI is passed.

@wzhudev
Copy link
Member Author

wzhudev commented Oct 16, 2021

I am afraid that when used with nzNoAnimation it may shift the first time it appears. Need more investigation here. In the worst case we may need to implement a position strategy by ourselves.

It works. :)

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #7010 (cfd5aad) into master (9700e89) will decrease coverage by 0.02%.
The diff coverage is 82.85%.

❗ Current head cfd5aad differs from pull request most recent head 752d43c. Consider uploading reports for the commit 752d43c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7010      +/-   ##
==========================================
- Coverage   89.51%   89.48%   -0.03%     
==========================================
  Files         488      488              
  Lines       15792    15822      +30     
  Branches     2435     2441       +6     
==========================================
+ Hits        14136    14159      +23     
- Misses       1016     1021       +5     
- Partials      640      642       +2     
Impacted Files Coverage Δ
components/tooltip/base.ts 93.54% <60.00%> (+0.06%) ⬆️
components/core/overlay/nz-connected-overlay.ts 85.71% <84.61%> (-14.29%) ⬇️
components/popconfirm/popconfirm.ts 96.15% <100.00%> (+0.04%) ⬆️
components/popover/popover.ts 100.00% <100.00%> (ø)
components/tooltip/tooltip.ts 100.00% <100.00%> (ø)
components/time-picker/time-holder.ts 95.78% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 81.56% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9700e89...752d43c. Read the comment docs.

@wzhudev wzhudev marked this pull request as ready for review November 4, 2021 12:32
@wzhudev wzhudev changed the title feat(module:tooltip, etc): add arrow point at center feature feat(module:tooltip, etc): add arrow point at center Nov 4, 2021
@wzhudev wzhudev requested a review from hsuanxyz November 4, 2021 12:32
@wzhudev wzhudev force-pushed the feature/arrow-point-at-center branch from d75e68f to bedc6a5 Compare November 4, 2021 12:36
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 7fac8eb into master Nov 22, 2021
@hsuanxyz hsuanxyz deleted the feature/arrow-point-at-center branch December 2, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover arrow points to the center of the target
2 participants