Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: core): correct hidden behavior #6919

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fix(module: core): correct hidden behavior #6919

merged 1 commit into from
Nov 4, 2021

Conversation

hungtcs
Copy link
Contributor

@hungtcs hungtcs commented Aug 11, 2021

  • fix hidden attribute behavior
  • make hidden behavior same as angular

Closes #6918

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6918

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hungtcs hungtcs requested a review from vthinkxie as a code owner August 11, 2021 03:51
@zorro-bot
Copy link

zorro-bot bot commented Aug 11, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #6919 (bad8a61) into master (d392b2e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6919      +/-   ##
==========================================
+ Coverage   89.50%   89.51%   +0.01%     
==========================================
  Files         489      489              
  Lines       15805    15804       -1     
  Branches     2428     2427       -1     
==========================================
+ Hits        14146    14147       +1     
  Misses       1016     1016              
+ Partials      643      641       -2     
Impacted Files Coverage Δ
...ore/transition-patch/transition-patch.directive.ts 100.00% <100.00%> (+6.66%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.03% <0.00%> (ø)
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d392b2e...bad8a61. Read the comment docs.

- fix hidden attribute behavior
- make hidden behavior same as angular

Closes #6918
Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hsuanxyz hsuanxyz merged commit 987b1ca into NG-ZORRO:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the behavior of 'hidden' is incorrect when the value is 'undefined', and it is different from angular
3 participants