Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:core,dropdown,table): add config for backdrop #6783

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

QichenZhu
Copy link
Contributor

@QichenZhu QichenZhu commented Jun 18, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6951

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #6783 (c198829) into master (d1cdd0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6783    +/-   ##
========================================
  Coverage   89.61%   89.61%            
========================================
  Files         488      488            
  Lines       15778    15783     +5     
  Branches     2568     2423   -145     
========================================
+ Hits        14139    14144     +5     
  Misses        997      997            
  Partials      642      642            
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/dropdown/dropdown.directive.ts 88.78% <100.00%> (+0.32%) ⬆️
...onents/table/src/addon/filter-trigger.component.ts 45.83% <100.00%> (+4.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1cdd0e...c198829. Read the comment docs.

@QichenZhu QichenZhu marked this pull request as ready for review June 18, 2021 07:31
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants