Skip to content

Commit

Permalink
Deprecate the AWS ECS detector (#5638)
Browse files Browse the repository at this point in the history
Towards #5543
  • Loading branch information
MrAlias authored May 23, 2024
1 parent 6e707b3 commit 8b96509
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5551]. (#5598)
- The `go.opentelemetry.io/contrib/detectors/aws/ec2` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#5636)
- The `go.opentelemetry.io/contrib/detectors/aws/ecs` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5543]. (#5637)

[#5542]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542
[#5543]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543
[#5551]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5551

## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21
Expand Down
9 changes: 9 additions & 0 deletions detectors/aws/ecs/ecs.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// Package ecs provide an OpenTelemetry resource detector for AWS ECS
// instances.
//
// Deprecated: ecs has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: /~https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543
package ecs // import "go.opentelemetry.io/contrib/detectors/aws/ecs"

import (
Expand Down
1 change: 1 addition & 0 deletions detectors/aws/ecs/go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Deprecated: ecs has no Code Owner.
module go.opentelemetry.io/contrib/detectors/aws/ecs

go 1.21
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/ecs/test/ecs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"strings"
"testing"

ecs "go.opentelemetry.io/contrib/detectors/aws/ecs"
ecs "go.opentelemetry.io/contrib/detectors/aws/ecs" // nolint:staticcheck // deprecated.
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/sdk/resource"
semconv "go.opentelemetry.io/otel/semconv/v1.25.0"
Expand Down

0 comments on commit 8b96509

Please sign in to comment.