Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNI product pages should show PNI OG image #7165

Closed
kristinashu opened this issue Aug 3, 2021 · 4 comments · Fixed by #7655
Closed

PNI product pages should show PNI OG image #7165

kristinashu opened this issue Aug 3, 2021 · 4 comments · Fixed by #7655
Assignees
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering

Comments

@kristinashu
Copy link

Product pages on PNI are showing the generic Mozilla OG image.

image

They should show the PNI OG image.
image

Note: Category pages should show continue to show the custom category OG when one has been uploaded.

@kristinashu kristinashu added engineering buyer's guide 🛍 Issues related to the buyer's guide labels Aug 3, 2021
@Pomax
Copy link
Contributor

Pomax commented Aug 3, 2021

It looks like the product page implements a block social_image but that block seems to have disappeared from the "higher up" templates. Let's find out when we lost it,

@Pomax Pomax self-assigned this Aug 3, 2021
@jamilasnell jamilasnell assigned danielfmiranda and unassigned Pomax Sep 13, 2021
@kristinashu
Copy link
Author

cc @nancyt1 so she I'll get a ping when this is fixed

@kristinashu
Copy link
Author

Sorry, I messed up with this ticket! This should be about fixing the Category share info. Currently Category pages are showing the general PNI image and info but it should show the custom up that was uploaded.

E.g. https://foundation.mozilla.org/en/privacynotincluded/categories/video-call-apps/

Currently looks like:

image

But it should show the custom video call image that was uploaded:

CMS
image

Image that was uploaded
image

Sorry @nancyt1 @danielfmiranda! I'm not sure how I mixed this up! I must have been doing too much multitasking.

@kristinashu
Copy link
Author

Thank you for clarifying Daniel! Categories have been done here #7441, just hasn't been merged to the main site yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering
Projects
None yet
3 participants