-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/filter #296
Features/filter #296
Conversation
* | ||
* Created by gupele on 7/26/2016. | ||
*/ | ||
public class DebugProcessor implements TelemetryProcessor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth to make this sample a little easier to read:
- I would rename to SampleProcessor (instead of DebugProcessor)
- Maybe rename setBad to setPass
- Add documentation that explains the goal of the filter and that in the sample filter setPass chooses whether to pass all telemetry or to drop all telemetry.
Any documentation on how to configure the processors that came in 1.0.5? For example how to configure the |
Hi @jgogstad, The filters go into a new XML tag "TelemetryProcessor". There you can choose and customize the built in ones and/or new custom filters For example,
In this example the configuration file declares built in filters and one custom one. The method to implement is Filters are a good way to filter out telemetries you don't care for and by doing so reduce the traffic. The filter can get data from configuration by having a 'setXXX' method that matches its property name. <Processor type="full.path.to.CustomFilter> The framework will instantiate the class and will use reflection to set the value in the proper method (please read the 'SampleFilter). The framework also sets its own 'common' filters to ease the work of users. The following are the current 'built in' filters TraceTelemetryFilter PageViewTelemetryFilter
RequestTelemetryFilter
SyntheticSourceFilter TelemetryEventFilter We will soon have blog post for that and please note that we are working to add more 'built in' filters and enhance the current ones. Thanks |
Thanks for the clarification! I tried your sample configuration, and it resulted in a |
No description provided.