Add new ledger live app bridge #10171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask-extension into ledger-poc-integration
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
reviewed
Jan 11, 2021
| } | ||
|
|
||
| renderTutorialSteps() { | ||
| renderLedgerTutorialSteps() { |
There was a problem hiding this comment.
Each of these steps needs a key attribute to prevent a warning.
darkwing
reviewed
Jan 14, 2021
| <p className="hw-connect__msg">{step.message}</p> | ||
| <img | ||
| className="hw-connect__step-asset" | ||
| src={`images/${step.asset}.svg`} |
There was a problem hiding this comment.
I saw the following request in Chrome, and I think this line may be the culprit:
chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/images/undefined.svg
|
The current status from my testing is:
|
3 tasks
|
Superceded by #10293 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9826
Implements new hardware wallet tutorial design and adds new ledger live app bridge support.
Depends on:
MetaMask/eth-ledger-bridge-keyring#51
MetaMask/eth-ledger-bridge-keyring#52