Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[! NSFW IMAGE!] NSFW Toggle has no effect, NSFW content still displays. #685

Closed
tranquilcarbon opened this issue Jul 15, 2023 · 3 comments · Fixed by #738
Closed

[! NSFW IMAGE!] NSFW Toggle has no effect, NSFW content still displays. #685

tranquilcarbon opened this issue Jul 15, 2023 · 3 comments · Fixed by #738
Assignees
Labels
bug Something isn't working or working properly high priority should be implemented or fixed soon nsfw issues related to nsfw function question Further information is requested

Comments

@tranquilcarbon
Copy link

Describe the bug
A clear and concise description of what the bug is.

When I log into my sh.itjust.works instance I see NSFW posts despite the fact that hide NSFW is toggled on. I have verified that the problem occurs with both the iPad and iPhone version and have fresh installed the app to verify that the problem is not due to corruption.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'

  2. Click on '....'

  3. Scroll down to '....'

  4. See error

  5. Install lemmy

  6. Log into sh.itjust.works, make sure hide NSFW is enabled.

  7. Go to the “all” mode on the top right of the screen

  8. Scroll until you see a NSFW post.

Expected behavior
A clear and concise description of what you expected to happen.

NSFW posts should not appear when the hide NSFW toggle is enabled.

Screenshots
If applicable, add screenshots to help explain your problem.
IMG_0126

Smartphone (please complete the following information):

  • Device: iPad Air 3
  • OS: iOS 16.5.1 (20F75)
  • Version 0.3(1) testflight

Logs:
If you wish to submit any debug logs, you may do so by doing the following:

  • Navigate to Settings
  • Tap version number 5 times
  • Press "Send Logs"

This will open an email in your mail app with the logs in the body of the email.

If you want, you can post them here. However, although there should not be any PII inside of the logs, it may be best to just send them privately. If you do want to post them here, please either find and provide the applicable parts of the logs, or check them for any PII.

Additional context
Add any other context about the problem here.

@tranquilcarbon tranquilcarbon added the bug Something isn't working or working properly label Jul 15, 2023
@tranquilcarbon tranquilcarbon changed the title NSFW Toggle has no effect, NSFW content still displays. [! NSFW IMAGE!] NSFW Toggle has no effect, NSFW content still displays. Jul 15, 2023
@gkasdorf
Copy link
Collaborator

Oh, interesting. Let me look at what might have happened there. I think the better options while I'm at it is to just change to using the Lemmy-account-specific toggle for this instead of hiding it manually in-app.

Thanks.

@gkasdorf gkasdorf self-assigned this Jul 15, 2023
@gkasdorf gkasdorf added the high priority should be implemented or fixed soon label Jul 15, 2023
@eoddc5 eoddc5 added the nsfw issues related to nsfw function label Jul 15, 2023
@gkasdorf
Copy link
Collaborator

So here's a question: Did this happen with the hide NSFW setting enabled on the actually Lemmy instance as well? If that's the case then this shouldn't have happened at all.

I'm unable to reproduce getting NSFW to show in my feed with the hide toggled just in-app, although I also have NSFW enabled in the browser PWA. Curious what might have been the cause of this.

@gkasdorf gkasdorf added the question Further information is requested label Jul 17, 2023
@gkasdorf
Copy link
Collaborator

Just ran across the reason for this I think in the codebase...fixing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or working properly high priority should be implemented or fixed soon nsfw issues related to nsfw function question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants