readStream options are sticky

[chesles]

When I get a readStream({reverse: true}), followed by a plain readStream(), I get the documents out in reverse order again, unless I specify reverse: false. start and end behave similarly, the last value for each option acting as the default value for the next call.

Example:

> db.readStream().on('data', console.log)
{ key: '0', value: "blah" }
{ key: '1', value: "foo" }
{ key: '2', value: "bar" }
{ key: '3', value: "..." }

# ok, reverse the stream
> db.readStream({reverse: true}).on('data', console.log)
{ key: '3', value: "..." }
{ key: '2', value: "bar" }
{ key: '1', value: "foo" }
{ key: '0', value: "blah" }

# stream is still reversed
> db.readStream().on('data', console.log)
{ key: '3', value: "..." }
{ key: '2', value: "bar" }
{ key: '1', value: "foo" }
{ key: '0', value: "blah" }

# back to normal with reverse: false
> db.readStream({reverse: false}).on('data', console.log)
{ key: '0', value: "blah" }
{ key: '1', value: "foo" }
{ key: '2', value: "bar" }
{ key: '3', value: "..." }

[tilgovi]

It looks like the problem is in this line: /~https://github.com/rvagg/node-levelup/blob/master/lib/levelup.js#L209

I think it should read:

options = extend(extend({}, this._options), typeof options == 'object' ? options : {})

In other words, properties from this._options should be copied into a fresh object and that object should be extended by the options passed as an argument to db.readStrem. Currently, the code is extending this._options each time.

[rvagg]

Thanks for picking this up @chesles, nice find! I have a unit test for this now and it's fixed in 0.1.1.

I'd be happy to hear about any issues you're having with the lib in pouchdb; my uses for it currently aren't as extensive as what you're going to put it through so I'm sure you'll pick up more things that I haven't run in to. I'm also happy to consider any functionality you think belongs at this level rather than in pouchdb.

[chesles]

Thanks @rvagg! I do have a few other small issues I'll open as soon as I have time. Thanks for a great library :)