✨ (dmk): Add sendApdu in internal API interface

.changeset/funny-ads-destroy.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-management-kit": minor
+---
+
+Add sendApdu in internal API interface

.changeset/gold-needles-sell.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-signer-kit-bitcoin": minor
+---
+
+Add sendApdu in internal API interface

.changeset/grumpy-olives-shave.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-signer-kit-solana": minor
+---
+
+Add sendApdu in internal API interface

.changeset/smooth-fireants-sip.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-signer-kit-ethereum": minor
+---
+
+Add sendApdu in internal API interface

packages/device-management-kit/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ledgerhq/device-management-kit",
   "version": "0.6.0",
-  "private": true,
+  "private": false,
   "license": "Apache-2.0",
   "exports": {
     ".": {

packages/device-management-kit/src/api/device-action/DeviceAction.ts

@@ -1,7 +1,9 @@
+import { type Either } from "purify-ts";
 import { type Observable } from "rxjs";
 
 import { type Command } from "@api/command/Command";
 import { type CommandResult } from "@api/command/model/CommandResult";
+import { type ApduResponse } from "@api/device-session/ApduResponse";
 import { type DeviceSessionState } from "@api/device-session/DeviceSessionState";
 import { type DmkError } from "@api/Error";
 import { type ManagerApiService } from "@internal/manager-api/service/ManagerApiService";
@@ -10,6 +12,9 @@ import { type SecureChannelService } from "@internal/secure-channel/service/Secu
 import { type DeviceActionState } from "./model/DeviceActionState";
 
 export type InternalApi = {
+  readonly sendApdu: (
+    apdu: Uint8Array,
+  ) => Promise<Either<DmkError, ApduResponse>>;
   readonly sendCommand: <Response, Args, ErrorStatusCodes>(
     command: Command<Response, Args, ErrorStatusCodes>,
   ) => Promise<CommandResult<Response, ErrorStatusCodes>>;

packages/device-management-kit/src/api/device-action/__test-utils__/makeInternalApi.ts

@@ -2,6 +2,7 @@ import { type Mocked } from "vitest";
 
 import { type InternalApi } from "@api/device-action/DeviceAction";
 
+const sendApduMock = vi.fn();
 const sendCommandMock = vi.fn();
 const apiGetDeviceSessionStateMock = vi.fn();
 const apiGetDeviceSessionStateObservableMock = vi.fn();
@@ -11,6 +12,7 @@ const getSecureChannelServiceMock = vi.fn();
 
 export function makeDeviceActionInternalApiMock(): Mocked<InternalApi> {
   return {
+    sendApdu: sendApduMock,
     sendCommand: sendCommandMock,
     getDeviceSessionState: apiGetDeviceSessionStateMock,
     getDeviceSessionStateObservable: apiGetDeviceSessionStateObservableMock,

packages/device-management-kit/src/internal/device-session/model/DeviceSession.ts

@@ -31,6 +31,11 @@ export type SessionConstructorArgs = {
   id?: DeviceSessionId;
 };
 
+type SendApduOptions = {
+  isPolling?: boolean;
+  triggersDisconnection?: boolean;
+};
+
 /**
  * Represents a session with a device.
  */
@@ -103,10 +108,7 @@ export class DeviceSession {
 
   async sendApdu(
     rawApdu: Uint8Array,
-    options: {
-      isPolling: boolean;
-      triggersDisconnection: boolean;
-    } = {
+    options: SendApduOptions = {
       isPolling: false,
       triggersDisconnection: false,
     },
@@ -116,7 +118,9 @@ export class DeviceSession {
       return Left(new DeviceBusyError());
     }
 
-    if (!options.isPolling) this.updateDeviceStatus(DeviceStatus.BUSY);
+    if (!options.isPolling) {
+      this.updateDeviceStatus(DeviceStatus.BUSY);
+    }
 
     const errorOrResponse = await this._connectedDevice.sendApdu(
       rawApdu,
@@ -163,6 +167,7 @@ export class DeviceSession {
     deviceAction: DeviceAction<Output, Input, Error, IntermediateValue>,
   ): ExecuteDeviceActionReturnType<Output, Error, IntermediateValue> {
     const { observable, cancel } = deviceAction._execute({
+      sendApdu: async (apdu: Uint8Array) => this.sendApdu(apdu),
       sendCommand: async <Response, ErrorStatusCodes, Args>(
         command: Command<Response, ErrorStatusCodes, Args>,
       ) => this.sendCommand(command),

packages/signer/signer-btc/package.json

@@ -4,7 +4,7 @@
   "license": "Apache-2.0",
   "main": "lib/cjs/index.js",
   "types": "lib/cjs/index.d.ts",
-  "private": true,
+  "private": false,
   "exports": {
     ".": {
       "types": "./lib/types/index.d.ts",

packages/signer/signer-btc/src/internal/app-binder/device-action/__test-utils__/makeInternalApi.ts

@@ -1,6 +1,7 @@
 import { type InternalApi } from "@ledgerhq/device-management-kit";
 import { type Mocked } from "vitest";
 
+const sendApduMock = vi.fn();
 const sendCommandMock = vi.fn();
 const apiGetDeviceSessionStateMock = vi.fn();
 const apiGetDeviceSessionStateObservableMock = vi.fn();
@@ -10,6 +11,7 @@ const getSecureChannelServiceMock = vi.fn();
 
 export function makeDeviceActionInternalApiMock(): Mocked<InternalApi> {
   return {
+    sendApdu: sendApduMock,
     sendCommand: sendCommandMock,
     getDeviceSessionState: apiGetDeviceSessionStateMock,
     getDeviceSessionStateObservable: apiGetDeviceSessionStateObservableMock,

packages/signer/signer-eth/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ledgerhq/device-signer-kit-ethereum",
   "version": "1.1.0",
-  "private": true,
+  "private": false,
   "license": "Apache-2.0",
   "exports": {
     ".": {

packages/signer/signer-eth/src/internal/app-binder/device-action/__test-utils__/makeInternalApi.ts

@@ -1,14 +1,17 @@
 import { type InternalApi } from "@ledgerhq/device-management-kit";
 import { type Mocked } from "vitest";
 
+const sendApduMock = vi.fn();
 const sendCommandMock = vi.fn();
 const apiGetDeviceSessionStateMock = vi.fn();
 const apiGetDeviceSessionStateObservableMock = vi.fn();
 const setDeviceSessionStateMock = vi.fn();
 const getManagerApiServiceMock = vi.fn();
 const getSecureChannelServiceMock = vi.fn();
+
 export function makeDeviceActionInternalApiMock(): Mocked<InternalApi> {
   return {
+    sendApdu: sendApduMock,
     sendCommand: sendCommandMock,
     getDeviceSessionState: apiGetDeviceSessionStateMock,
     getDeviceSessionStateObservable: apiGetDeviceSessionStateObservableMock,

packages/signer/signer-solana/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ledgerhq/device-signer-kit-solana",
   "version": "1.1.0",
-  "private": true,
+  "private": false,
   "license": "Apache-2.0",
   "exports": {
     ".": {

packages/signer/signer-solana/src/internal/app-binder/device-action/__test-utils__/makeInternalApi.ts

@@ -1,6 +1,7 @@
 import { type InternalApi } from "@ledgerhq/device-management-kit";
 import { type Mocked } from "vitest";
 
+const sendApduMock = vi.fn();
 const sendCommandMock = vi.fn();
 const apiGetDeviceSessionStateMock = vi.fn();
 const apiGetDeviceSessionStateObservableMock = vi.fn();
@@ -10,6 +11,7 @@ const getSecureChannelServiceMock = vi.fn();
 
 export function makeDeviceActionInternalApiMock(): Mocked<InternalApi> {
   return {
+    sendApdu: sendApduMock,
     sendCommand: sendCommandMock,
     getDeviceSessionState: apiGetDeviceSessionStateMock,
     getDeviceSessionStateObservable: apiGetDeviceSessionStateObservableMock,