feat: await for hackConnect

LedgerHQ · Mar 21, 2024 · 321c5e7 · 321c5e7
1 parent f2f70da
commit 321c5e7
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 14 deletions.
diff --git a/.changeset/new-wolves-hope.md b/.changeset/new-wolves-hope.md
@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-sdk-core": patch
+---
+
+use promise
diff --git a/packages/core/src/api/DeviceSdk.ts b/packages/core/src/api/DeviceSdk.ts
@@ -69,8 +69,10 @@ export class DeviceSdk {
   }
 
   // HACKATHON STUFF
-  hackConnectAndDiscover() {
-    this.container.get<HackathonService>(hackTypes.HackathonService).discover();
+  async hackConnectAndDiscover() {
+    await this.container
+      .get<HackathonService>(hackTypes.HackathonService)
+      .discover();
   }
 
   hackDisconnect() {

diff --git a/packages/core/src/internal/hackathon/HackathonService.ts b/packages/core/src/internal/hackathon/HackathonService.ts
@@ -131,18 +131,25 @@ export class HackathonService {
     this.connectedDevice.removeEventListener("inputreport", this.listener);
   }
 
-  discover() {
-    return this.startDiscoveringUseCase.execute().subscribe({
-      next: (device) => {
-        this.discoveredDevice = device;
-        this.connect().catch((err) => console.log(err));
-      },
-      complete: () => {
-        this.stopDiscoveringUseCase.execute();
-      },
-      error: (error) => {
-        console.error(error);
-      },
+  async discover() {
+    return new Promise((res, rej) => {
+      this.startDiscoveringUseCase.execute().subscribe({
+        next: (device) => {
+          this.discoveredDevice = device;
+          this.connect()
+            .then(() => {
+              res(undefined);
+            })
+            .catch((err) => console.log(err));
+        },
+        complete: () => {
+          this.stopDiscoveringUseCase.execute();
+        },
+        error: (error) => {
+          rej(error);
+          console.error(error);
+        },
+      });
     });
   }