Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ZB-SP1000 #7977

Merged
merged 2 commits into from
Sep 13, 2024
Merged

support ZB-SP1000 #7977

merged 2 commits into from
Sep 13, 2024

Conversation

xsp1989
Copy link
Contributor

@xsp1989 xsp1989 commented Sep 12, 2024

support ZB-SP1000

Koenkk
Koenkk reviewed Sep 12, 2024
View reviewed changes
src/devices/easyiot.ts Outdated
fingerprint: [{modelID: 'ZB-SP1000', manufacturerName: 'easyiot'}],
model: 'ZB-SP1000',
vendor: 'easyiot',
description: 'ZB-SP1000 is an MP3 player that can support 1,000 voices. You can play any specified voice. You only \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you shorten the description to 1 sentence?

@Koenkk Koenkk merged commit 24e7045 into Koenkk:master Sep 13, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Sep 13, 2024

Thanks!

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is ZB-SP1000.png
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@Koenkk Koenkk mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsp1989 @Koenkk