Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support no custom domain/dns/certs #305

Merged
merged 8 commits into from
May 26, 2023

Conversation

hikeeba
Copy link
Contributor

@hikeeba hikeeba commented May 25, 2023

Proposed changes

Add support for websites that do not need or have a domain name yet.

Commentary

Anything else we should know when reviewing?

Types of Changes

What types of changes does your code introduce? Check all the boxes that apply

  • Bugfix (non - breaking change which fixes an issue)
  • New feature or Enhancement (non - breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation, refactoring, dependency upgrade, etc.)

Chores

Check all the boxes that apply

  • This PR includes breaking changes which are documented in the description and associated commit messages (see the Contributing Guide for more information on how this should be done)
  • This PR impacts documentation, and it has been updated (or an issue has been created and linked)
  • This PR's changes are covered by the automated tests

@hikeeba hikeeba requested a review from NathanTCz May 25, 2023 17:56
@hikeeba hikeeba changed the title support no custom domain/dns/certs feat: support no custom domain/dns/certs May 25, 2023
hikeeba and others added 3 commits May 25, 2023 14:08
Signed-off-by: github-actions <github-actions@github.com>
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: +0.25 🎉

Comparison is base (5ad8f6f) 92.57% compared to head (c7929b4) 92.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   92.57%   92.83%   +0.25%     
==========================================
  Files          34       34              
  Lines         566      586      +20     
  Branches      138      154      +16     
==========================================
+ Hits          524      544      +20     
  Misses         42       42              
Impacted Files Coverage Δ
src/single-page-app.ts 88.00% <83.33%> (+1.63%) ⬆️
src/website.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NathanTCz NathanTCz merged commit c108ce6 into main May 26, 2023
@NathanTCz NathanTCz deleted the feature/no-domain-or-zone-required branch May 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants