Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repro] Consume published libraries #106

Closed
wants to merge 1 commit into from
Closed

[Repro] Consume published libraries #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ junitVersion = "4.13.2"
junitExtVersion = "1.1.5"
multidexVersion = "2.0.1"
materialVersion = "1.10.0"
kakaoversion = "3.4.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing to 3.5.0 fails build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good day, thanks for the reporting about the issue. Hm, that is quite strange, because we migrated from 3.4.1 to 3.5.0 without any issues. And we have more than 1.3k UI tests.

As well, could you provide any information about which methods visibility has been affected?

Unfortunately I'm on vacation and will be back at the end of December

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I just checked the getResourceDwarable() function that you imported into the PR, and it's signature hasn't changed since the last 3 years. Could you please add more details on to what exactly has changed it's visibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the signature hasn't changed, totally agree with that.
However, if you checkout this branch which consumes the released library you'll realise that the function is visible in 3.4.1 but not in 3.5.0.
I checked the source of the published library and I see the function. I'm not sure what's going on in terms of visibility
Screenshot 2023-12-11 at 09 44 24

Screenshot 2023-12-11 at 09 44 37

kakaoClickversion = "1.0.0"

detekt = "1.17.1"

Expand Down Expand Up @@ -57,3 +59,6 @@ org-jetbrains-dokka-kotlinAsJavaPlugin = { group = "org.jetbrains.dokka", name =
org-jetbrains-dokka-dokkaGradlePlugin = { group = "org.jetbrains.dokka", name = "dokka-gradle-plugin", version.ref = "dokkaVersion" }

org-kohsuke-githubApi = { group = "org.kohsuke", name = "github-api", version.ref = "githubApiVersion" }

kakao-published = { group = "io.github.kakaocup", name = "kakao", version.ref = "kakaoversion" }
kakao-click-published = { group = "io.github.kakaocup", name = "kakao-ext-clicks", version.ref = "kakaoClickversion" }
4 changes: 2 additions & 2 deletions sample/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ dependencies {

testImplementation(libs.junit.junit)

androidTestImplementation(project(":kakao"))
androidTestImplementation(project(":kakao-ext-clicks"))
androidTestImplementation(libs.kakao.published)
androidTestImplementation(libs.kakao.click.published)

androidTestImplementation(libs.androidx.annotation)
androidTestImplementation(libs.androidx.test.runner)
Expand Down
2 changes: 2 additions & 0 deletions sample/src/androidTest/kotlin/io/github/kakaocup/sample/AlertDialogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package io.github.kakaocup.sample

import androidx.test.ext.junit.rules.ActivityScenarioRule
import androidx.test.internal.runner.junit4.AndroidJUnit4ClassRunner
import io.github.kakaocup.kakao.common.utilities.getResourceDrawable
import io.github.kakaocup.kakao.screen.Screen
import io.github.kakaocup.sample.screen.AlertDialogActivityScreen
import org.junit.Rule
Expand All @@ -17,6 +18,7 @@ class AlertDialogTest {
@Test
fun testAlertDialog() {
Screen.onScreen<AlertDialogActivityScreen> {
getResourceDrawable(R.drawable.ic_android_black_24dp)
showAlertDialogButton {
click()
}
Expand Down